Github user jiny2 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1314#discussion_r154278905
  
    --- Diff: src/backend/access/external/Makefile ---
    @@ -26,7 +26,7 @@ subdir = src/backend/access/external
     top_builddir = ../../../..
     include $(top_builddir)/src/Makefile.global
     
    -OBJS = fileam.o url.o libchurl.o hd_work_mgr.o pxfuriparser.o pxfheaders.o 
\
    +OBJS = fileam.o plugstorage.o url.o libchurl.o hd_work_mgr.o 
pxfuriparser.o pxfheaders.o \
    --- End diff --
    
    I think it is better to add this new object to the tail of OBJS list


---

Reply via email to