[GitHub] incubator-hawq pull request #1322: Support Hive OpenCSVSerde

[lavjain]

Github user lavjain commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1322#discussion_r156481970
  
    --- Diff: 
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveLineBreakAccessor.java
 ---
    @@ -43,7 +43,7 @@
         public HiveLineBreakAccessor(InputData input) throws Exception {
             super(input, new TextInputFormat());
             ((TextInputFormat) inputFormat).configure(jobConf);
    -        HiveUserData hiveUserData = HiveUtilities.parseHiveUserData(input, 
PXF_HIVE_SERDES.LAZY_SIMPLE_SERDE);
    +        HiveUserData hiveUserData = HiveUtilities.parseHiveUserData(input, 
PXF_HIVE_SERDES.LAZY_SIMPLE_SERDE, PXF_HIVE_SERDES.CSV_SERDE);
    --- End diff --
    
    I second that. We should support all serdes (Hive is responsible for them)


---