Github user wengyanqing commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1349#discussion_r177940619
  
    --- Diff: contrib/vexecutor/vexecutor.c ---
    @@ -21,15 +21,23 @@
     #include "vexecutor.h"
     #include "utils/guc.h"
     #include "vcheck.h"
    +#include "miscadmin.h"
    +#include "tuplebatch.h"
    +#include "executor/nodeTableScan.h"
    +#include "catalog/catquery.h"
    +#include "cdb/cdbvars.h"
    +#include "execVScan.h"
     
     PG_MODULE_MAGIC;
    -
    +#define BATCHSIZE 1024
    --- End diff --
    
    It's better to make BATCHSIZE as GUC so that we could tune this value 
easily.


---

Reply via email to