Github user benchristel commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r200792239
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/TimedProxyUGI.java ---
@@ -0,0 +1,81 @@
+package org.apache.hawq.pxf.service;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.Delayed;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.hadoop.security.UserGroupInformation;
+
+public class TimedProxyUGI implements Delayed {
+
+ private long startTime;
+ private UserGroupInformation proxyUGI;
+ private SegmentTransactionId session;
+ AtomicInteger inProgress = new AtomicInteger();
+
+ public TimedProxyUGI(UserGroupInformation proxyUGI,
SegmentTransactionId session) {
+ this.startTime = System.currentTimeMillis();
+ this.proxyUGI = proxyUGI;
+ this.session = session;
+ inProgress.incrementAndGet();
+ }
+
+ public UserGroupInformation getProxyUGI() {
--- End diff --
If a "ProxyUGI" is a wrapper around UGI (as the name of this class
implies), maybe the name of this method should be `getUGI`. The corresponding
field could be named `ugi` or `delegateUGI` or something.
---
