Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r201518811
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/servlet/SecurityServletFilter.java
---
@@ -42,8 +47,13 @@
private static final Log LOG =
LogFactory.getLog(SecurityServletFilter.class);
private static final String USER_HEADER = "X-GP-USER";
- private static final String MISSING_HEADER_ERROR =
String.format("Header %s is missing in the request", USER_HEADER);
- private static final String EMPTY_HEADER_ERROR = String.format("Header
%s is empty in the request", USER_HEADER);
+ private static final String SEGMENT_ID_HEADER = "X-GP-SEGMENT-ID";
+ private static final String TRANSACTION_ID_HEADER = "X-GP-XID";
+ private static final String FRAGMENT_INDEX_HEADER =
"X-GP-FRAGMENT-INDEX";
+ private static final String FRAGMENT_COUNT_HEADER =
"X-GP-FRAGMENT-COUNT";
+ private static final String MISSING_HEADER_ERROR = "Header %s is
missing in the request";
+ private static final String EMPTY_HEADER_ERROR = "Header %s is empty
in the request";
+ private static UGICache cache = new UGICache();
--- End diff --
this doesn't have to be static, create a single instance in the init()
method
---
