Github user lavjain commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1379#discussion_r202120502
  
    --- Diff: 
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java ---
    @@ -129,90 +135,93 @@ public void release(Entry timedProxyUGI, boolean 
forceClean) {
         }
     
         /**
    -     * Iterate through all the entries in the queue for the given segment
    +     * Iterate through all the entries in the queue for the given 
session's segment
          * and close expired {@link UserGroupInformation}, otherwise it resets
          * the timer for every non-expired entry.
          *
    -     * @param segmentId
    +     * @param session
          */
    -    private void cleanup(Integer segmentId) {
    +    private void cleanup(SessionId session) {
     
             Entry ugi;
    -        DelayQueue<Entry> delayQueue = getExpirationQueue(segmentId);
    +        DelayQueue<Entry> delayQueue = 
getExpirationQueue(session.getSegmentId());
    --- End diff --
    
    It might be better to pass the delayQueue to this method instead of doing a 
lookup again.


---

Reply via email to