Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437403
  
    --- Diff: src/backend/commands/tablecmds.c ---
    @@ -18041,11 +18646,11 @@ static Datum transformFormatOpts(char formattype, 
List *formatOpts, int numcols,
                          1 +                                                   
                /* space                                        */
                          4 + 1 + 1 + strlen(null_print) + 1 +  /* "null 'str'" 
                        */
                          1 +                                                   
                /* space                                        */
    -                     6 + 1 + 1 + strlen(escape) + 1;               /* 
"escape 'c' or 'off'         */
    +                     6 + 1 + 1 + strlen(escape) + 1;               /* 
"escape 'c' or 'off'         */
    --- End diff --
    
    Do not format the code if you don't change it logic


---

Reply via email to