[ 
https://issues.apache.org/jira/browse/HBASE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870361#action_12870361
 ] 

Benoit Sigoure commented on HBASE-2590:
---------------------------------------

Oh I see, I didn't realize you committed the first change way before I posted 
my patch.  JIRA doesn't show changes in the issue by default and there was no 
other indication of any work being done on it.  I couldn't reproduce the 
problem or see the same file you edited because I already had pulled your fix 
without knowing it!

So my patch doesn't fix anything, it just cleans up the script.  By removing 
the last unnecessary call to `sed' we can make sure we'll never run into this 
problem again.

> Failed parse of branch element in saveVersion.sh
> ------------------------------------------------
>
>                 Key: HBASE-2590
>                 URL: https://issues.apache.org/jira/browse/HBASE-2590
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Benoit Sigoure
>             Fix For: 0.21.0
>
>         Attachments: 0001-Fix-HBASE-2590.patch
>
>
> A mvn build would fail because of the string it was getting back from svn:
> {code}
>       [exec] not part of the command.
>       Execute:Java13CommandLauncher: Executing 'sh' with arguments:
>        '/home/X/Y/hadoop/branches/V.V/hbase/hbase-trunk/src/saveVersion.sh'
>         '0.21.0-SNAPSHOT'
>          '/home/X/Y/hadoop/branches/V.V/hbase-trunk/target/generated-sources'
>         The ' characters around the executable and arguments are
>          not part of the command.
>          [exec] sed: -e expression #6, char 48: unterminated `s' command
>          [exec] Result: 1
> {code}
> Path amended in the above to protect the innocent.
> The failure was around parse of branch.  Branch is not used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to