[
https://issues.apache.org/jira/browse/HBASE-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871314#action_12871314
]
HBase Review Board commented on HBASE-2579:
-------------------------------------------
Message from: "Todd Lipcon" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/84/#review54
-----------------------------------------------------------
Looks pretty good. The one thing I don't like is that checkAndMutate takes a
Writable, and then downcasts based on instanceof. Can we extract a common
interface between Put and Delete? maybe something like RowMutation or
RowOperation, which would have getRowLock and a "performMutation()" or
something? What do you guys think?
trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
<http://review.hbase.org/r/84/#comment308>
typo: executed
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/84/#comment309>
since this modifies its parameter, I don't know that it makes sense to also
return it. I'd make this void and add javadoc that it will mutate its arg (also
explain what it does)
- Todd
> Add atomic checkAndDelete support
> ---------------------------------
>
> Key: HBASE-2579
> URL: https://issues.apache.org/jira/browse/HBASE-2579
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Michael Dalton
> Fix For: 0.21.0
>
> Attachments: 2579-v2.patch, 2579.patch
>
>
> Currently HBase has support for atomic checkAndPut operations on individual
> rows. It would be very useful to also support atomic checkAndDelete. I have
> added support for atomic checkAndDelete to trunk and will provide the
> corresponding patch tonight after I merge in any upstream changes from the
> last few days.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
