[
https://issues.apache.org/jira/browse/HBASE-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871978#action_12871978
]
HBase Review Board commented on HBASE-2613:
-------------------------------------------
Message from: "Todd Lipcon" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/89/#review82
-----------------------------------------------------------
Ship it!
A little nervous about the sleeps in the test making it flaky, but let's push
it and fix if it ends up flaky. +1
- Todd
On 2010-05-26 15:12:24, Jean-Daniel Cryans wrote:
^bq.
^bq. -----------------------------------------------------------
^bq. This is an automatically generated e-mail. To reply, visit:
^bq. http://review.hbase.org/r/89/
^bq. -----------------------------------------------------------
^bq.
^bq. (Updated 2010-05-26 15:12:24)
^bq.
^bq.
^bq. Review request for hbase.
^bq.
^bq.
^bq. Summary
^bq. -------
^bq.
^bq. Patch that removes all the MSG_CALL_SERVER_STARTUP related code that was
screwing us more than helping us. Now, when a region server pings back with a
different start code, we just shut it down.
^bq.
^bq.
^bq. This addresses bug HBASE-2613.
^bq.
^bq.
^bq. Diffs
^bq. -----
^bq.
^bq. /trunk/src/main/java/org/apache/hadoop/hbase/HMsg.java 948611
^bq. /trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
948611
^bq.
/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
948611
^bq.
/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterWrongRS.java
PRE-CREATION
^bq.
^bq. Diff: http://review.hbase.org/r/89/diff
^bq.
^bq.
^bq. Testing
^bq. -------
^bq.
^bq.
^bq. Thanks,
^bq.
^bq. Jean-Daniel
^bq.
^bq.
> Remove the code around MSG_CALL_SERVER_STARTUP
> ----------------------------------------------
>
> Key: HBASE-2613
> URL: https://issues.apache.org/jira/browse/HBASE-2613
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.21.0
>
>
> Currently we have a weird piece of code in the master that handles region
> servers that report but that we don't know about. People likely see:
> {code}
> LOG.warn("Received report from unknown server -- telling it " +
> "to " + HMsg.CALL_SERVER_STARTUP + ": " + info.getServerName());
> {code}
> But I never saw that working.correctly, usually the region server will
> restar-ish and we will likely end up with double assignment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
