[ 
https://issues.apache.org/jira/browse/HBASE-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874215#action_12874215
 ] 

HBase Review Board commented on HBASE-1923:
-------------------------------------------

Message from: [email protected]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/87/#review108
-----------------------------------------------------------

Ship it!


This is a killer feature.  Ship it.  There is one nitpick in the below but can 
be done on commit (if its legit)


src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
<http://review.hbase.org/r/87/#comment658>

    duh



src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
<http://review.hbase.org/r/87/#comment659>

    Where is the javadoc that the tsv parse doesn't do escaping?



src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
<http://review.hbase.org/r/87/#comment660>

    Good



src/docs/src/documentation/content/xdocs/bulk-loads.xml
<http://review.hbase.org/r/87/#comment655>

    This is excellent.  We do have this though already: 
http://hbase.apache.org/docs/r0.20.4/api/org/apache/hadoop/hbase/mapreduce/package-summary.html#bulk
    
    We should scrap the above if we're going to go w/ this or update the former 
to include this.



src/docs/src/documentation/content/xdocs/bulk-loads.xml
<http://review.hbase.org/r/87/#comment656>

    method_s_



src/docs/src/documentation/content/xdocs/bulk-loads.xml
<http://review.hbase.org/r/87/#comment657>

    This is a killer feature


- stack





> Bulk incremental load into an existing table
> --------------------------------------------
>
>                 Key: HBASE-1923
>                 URL: https://issues.apache.org/jira/browse/HBASE-1923
>             Project: HBase
>          Issue Type: New Feature
>          Components: client, mapred, regionserver, scripts
>    Affects Versions: 0.21.0
>            Reporter: anty.rao
>            Assignee: Todd Lipcon
>         Attachments: hbase-1923-prelim.txt, hbase-1923.txt
>
>
> hbase-48 is about bulk load of a new table,maybe it's more practicable to 
> bulk load aganist a existing table.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to