[ 
https://issues.apache.org/jira/browse/HBASE-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874227#action_12874227
 ] 

HBase Review Board commented on HBASE-2635:
-------------------------------------------

Message from: "Todd Lipcon" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/110/#review110
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
<http://review.hbase.org/r/110/#comment662>

    Before we were hashing the entire byte array, not just the section of bytes 
corresponding to this writable. So the hashcode could be different even if the 
sliced bytes were the same. See new unit test for hashcode.


- Todd





> ImmutableBytesWritable ignores offset in several cases
> ------------------------------------------------------
>
>                 Key: HBASE-2635
>                 URL: https://issues.apache.org/jira/browse/HBASE-2635
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.4, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: hbase-2635.txt
>
>
> HBASE-2378 improved ImmutableBytesWritable's comparator, but there's still a 
> bug! We assume offset = 0, which makes the comparator function incorrectly 
> when the ImmutableBytesWritable is a slice into a larger byte array.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to