[
https://issues.apache.org/jira/browse/HBASE-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875942#action_12875942
]
ryan rawson commented on HBASE-2616:
------------------------------------
The flushcache is an old fix that helped make the tests less flakey. As you
may remember there are 2 threads:
- getting thread which when finished sets a 'done' flag
- putting thread
well the putting thread can get caught up in the HRegion calls when the cache
is full (this happens on my laptop frequently), so before we wait on the put
thread to be finished, we flush the cache which unblocks the put thread.
Note this happens _AFTER_ the asserts, therefore this has _nothing_ to do with
the test failures. This is how the code is on trunk, and how it should be.
> TestHRegion.testWritesWhileGetting flaky on trunk
> -------------------------------------------------
>
> Key: HBASE-2616
> URL: https://issues.apache.org/jira/browse/HBASE-2616
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Todd Lipcon
> Assignee: ryan rawson
> Priority: Critical
> Fix For: 0.20.5
>
> Attachments: HBASE-2616.patch
>
>
> Saw this failure on my internal hudson:
> junit.framework.AssertionFailedError: expected:<\x00\x00\x00\x96> but
> was:<\x00\x00\x01\x00>
> at
> org.apache.hadoop.hbase.HBaseTestCase.assertEquals(HBaseTestCase.java:684)
> at
> org.apache.hadoop.hbase.regionserver.TestHRegion.testWritesWhileGetting(TestHRegion.java:2334)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
