[ 
https://issues.apache.org/jira/browse/HBASE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877929#action_12877929
 ] 

HBase Review Board commented on HBASE-2712:
-------------------------------------------

Message from: "Jean-Daniel Cryans" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/170/
-----------------------------------------------------------

(Updated 2010-06-11 12:14:26.490410)


Review request for hbase.


Changes
-------

Fixed the potential NPE, and this one is against trunk.


Summary
-------

Patch against branch that does some refactoring and that fixes the bug at the 
same time. Adds a unit test that doesn't pass without the refactoring.

Urgent to review.


This addresses bug HBASE-2712.
    http://issues.apache.org/jira/browse/HBASE-2712


Diffs (updated)
-----

  /trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 
953830 
  /trunk/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java PRE-CREATION 

Diff: http://review.hbase.org/r/170/diff


Testing
-------


Thanks,

Jean-Daniel




> Cached region location that went stale won't recover if asking for first row
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-2712
>                 URL: https://issues.apache.org/jira/browse/HBASE-2712
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.4
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.20.5, 0.21.0
>
>
> Let's say that:
>  - A client cached the location of some region, not the first one in the table
>  - The RS that was holding it fails
>  - The first thing the client does after the failure is trying to reach the 
> first row of that region
> This will never recover, since HCM.deleteCachedLocation doesn't delete if the 
> row we asked for is the first row in a region. This looks a lot like 
> HBASE-1920, but there isn't enough information in that jira to say that it's 
> the same thing.
> This is a blocker, and it kills 0.20.5 RC2 (sorry).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to