[
https://issues.apache.org/jira/browse/HBASE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877939#action_12877939
]
HBase Review Board commented on HBASE-2223:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/76/#review191
-----------------------------------------------------------
I got as far as ReplicationLogCleaner... will continue later.
bin/replication/add_peer.rb
<http://review.hbase.org/r/76/#comment868>
Should you point at some replication documentation here? Is there such a
thing?
bin/replication/copy_tables_desc.rb
<http://review.hbase.org/r/76/#comment870>
This could get a bit annoying I'd say.
src/main/java/org/apache/hadoop/hbase/HConstants.java
<http://review.hbase.org/r/76/#comment871>
This has to go here? Can it go into one of the replication classes?
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
<http://review.hbase.org/r/76/#comment872>
Can't you just do c.get("key", defaultvalue)?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.hbase.org/r/76/#comment873>
You writing startcode into zk? Why not write servername -- the
host+port+startcode combo?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.hbase.org/r/76/#comment875>
Is this directory name? Confusingly named given rootdir+regLogPathStr only
adds up to repLogPath.
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment876>
Replication needs package documentation or else an article (like metrics)
-- oh, i see it later... nm
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment877>
Peers are named '1', '2'? Can't we have more meaningful names here?
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment878>
s/replicates/replicate/
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment879>
Use servername instead of startcode
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment880>
All RS's in a master cluster replicate?
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment881>
Should this class be called WRapper instaad of Helper?
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment882>
Registers it where?
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment883>
You mean 'ensemble' here rather than 'quorum' (Patrick will kill you if he
sees you calling it a 'quorum' when you mean the other)
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment884>
We keep up the replication position in zk? How much do we replicate in one
go? Its not a single edit, is it? We do this for every log file?
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment885>
LOG.warn instead?
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment887>
We return empty map if clusters size is == 1? Should that be clusters.size
== 0?
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment886>
Whats this about?
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment888>
Just logging errors? What if session expired (our discussion from last
day)?
src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment889>
Call it alpha
src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment890>
Whats this about? You need to run zk yourself but no zoo.cfg?
src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment891>
And if not? What if replicating single-family only?
src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment892>
Has to be offline? Will this always be the case?
src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment893>
whats ratio?
- stack
> Handle 10min+ network partitions between clusters
> -------------------------------------------------
>
> Key: HBASE-2223
> URL: https://issues.apache.org/jira/browse/HBASE-2223
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.21.0
>
> Attachments: HBASE-2223.patch
>
>
> We need a nice way of handling long network partitions without impacting a
> master cluster (which pushes the data). Currently it will just retry over and
> over again.
> I think we could:
> - Stop replication to a slave cluster if it didn't respond for more than 10
> minutes
> - Keep track of the duration of the partition
> - When the slave cluster comes back, initiate a MR job like HBASE-2221
> Maybe we want less than 10 minutes, maybe we want this to be all automatic or
> just the first 2 parts. Discuss.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
