[
https://issues.apache.org/jira/browse/HBASE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878110#action_12878110
]
HBase Review Board commented on HBASE-2353:
-------------------------------------------
Message from: "Todd Lipcon" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/167/
-----------------------------------------------------------
(Updated 2010-06-11 15:18:10.087969)
Review request for hbase, Kannan Muthukkaruppan and Ryan Rawson.
Changes
-------
Significantly changed patch - now batch put returns a list of status codes.
Also added some tests to make sure all the behavior is correct with locking,
bad families, etc.
I'd like to change HRegionInterface and HTable to return lists of status codes
at some point too, but I think that can wait for a later patch. This one at
least gets our performance back up by batching the syncs.
Summary
-------
I implemented the "mini batching" idea we talked about on the JIRA.
This currently breaks some of the error handling, so I dont intend to commit as
is, but everyone is busy so wanted to put a review up now while I tidy up the
rest.
This addresses bug HBASE-2353.
http://issues.apache.org/jira/browse/HBASE-2353
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/HConstants.java 1e59533
src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 62617ac
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java adc505b
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 541ec9b
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java ba04820
src/test/java/org/apache/hadoop/hbase/MultithreadedTestUtil.java 870f925
src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java 8a5206c
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java e75767d
Diff: http://review.hbase.org/r/167/diff
Testing
-------
Some PEs on a real sync-enabled cluster, seems faster but haven't done
scientific benchmarking.
Thanks,
Todd
> HBASE-2283 removed bulk sync optimization for multi-row puts
> ------------------------------------------------------------
>
> Key: HBASE-2353
> URL: https://issues.apache.org/jira/browse/HBASE-2353
> Project: HBase
> Issue Type: Bug
> Reporter: ryan rawson
> Assignee: Todd Lipcon
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: HBASE-2353_def_log_flush.patch
>
>
> previously to HBASE-2283 we used to call flush/sync once per put(Put[]) call
> (ie: batch of commits). Now we do for every row.
> This makes bulk uploads slower if you are using WAL. Is there an acceptable
> solution to achieve both safety and performance by bulk-sync'ing puts? Or
> would this not work in face of atomic guarantees?
> discuss!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
