[
https://issues.apache.org/jira/browse/HBASE-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878161#action_12878161
]
HBase Review Board commented on HBASE-2694:
-------------------------------------------
Message from: "Todd Lipcon" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/171/#review202
-----------------------------------------------------------
Ship it!
Skimmed it reasonably quickly, looks good.
Major concern is how often we catch and just log exceptions. In most cases I
think these are errors we can't recover from and it's best to throw RTE and
shut down the whole server.
Several places missing license headers.
trunk/src/main/java/org/apache/hadoop/hbase/executor/HBaseEventHandler.java
<http://review.hbase.org/r/171/#comment918>
use foreach form?
trunk/src/main/java/org/apache/hadoop/hbase/executor/HBaseEventHandler.java
<http://review.hbase.org/r/171/#comment919>
foreach form
trunk/src/main/java/org/apache/hadoop/hbase/executor/HBaseExecutorService.java
<http://review.hbase.org/r/171/#comment920>
== NONE.value, or if (this == NONE)?
trunk/src/main/java/org/apache/hadoop/hbase/executor/NamedThreadFactory.java
<http://review.hbase.org/r/171/#comment921>
You can just use this one:
http://guava-libraries.googlecode.com/svn/trunk/javadoc/com/google/common/util/concurrent/NamingThreadFactory.html
trunk/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java
<http://review.hbase.org/r/171/#comment922>
are these IOEs here and above really recoverable in any way? How could they
happen?
trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java
<http://review.hbase.org/r/171/#comment923>
license
trunk/src/main/java/org/apache/hadoop/hbase/master/handler/MasterOpenRegionHandler.java
<http://review.hbase.org/r/171/#comment924>
maybe add a LOG.debug here at least for now
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.hbase.org/r/171/#comment925>
again, are these LOG.errors really recoverable things?
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
<http://review.hbase.org/r/171/#comment926>
recoverable?
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
<http://review.hbase.org/r/171/#comment927>
can't wait til we refactor all this stuff
trunk/src/test/java/org/apache/hadoop/hbase/master/TestZKBasedCloseRegion.java
<http://review.hbase.org/r/171/#comment928>
license
- Todd
> Move RS to Master region open/close messaging into ZooKeeper
> ------------------------------------------------------------
>
> Key: HBASE-2694
> URL: https://issues.apache.org/jira/browse/HBASE-2694
> Project: HBase
> Issue Type: Sub-task
> Components: master, regionserver
> Reporter: Jonathan Gray
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: HBASE-2694-OPENSOURCE-TRUNK-zk-based-messaging-v2.patch,
> HBASE-2694-OPENSOURCE-TRUNK-zk-based-messaging.patch
>
>
> As a first step towards HBASE-2485, this issue is about changing the message
> flow of opening and closing of regions without actually changing the
> implementation of what happens on both the Master and RegionServer sides.
> This way we can debug the messaging changes before the introduction of more
> significant changes to the master architecture and handling of regions in
> transition.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
