[ 
https://issues.apache.org/jira/browse/HBASE-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878790#action_12878790
 ] 

HBase Review Board commented on HBASE-1025:
-------------------------------------------

Message from: "Todd Lipcon" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/179/#review221
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/179/#comment1002>

    as discussed on IRC, HFOF in the new world order post-1923 will now throw 
an error if you ask for its sequence number. Need to check 
StoreFile.isBulkLoad() or whatever before calling maxsequenceid - if it's a 
bulk load it shouldn't take part in calculations for seqid recovery


- Todd





> Reconstruction log playback has no bounds on memory used
> --------------------------------------------------------
>
>                 Key: HBASE-1025
>                 URL: https://issues.apache.org/jira/browse/HBASE-1025
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.21.0
>
>         Attachments: 1025-v2.txt, 1025-v3.txt, 1025-v5.patch, 1025.txt
>
>
> Makes a TreeMap and just keeps adding edits without regard for size of edits 
> applied; could cause OOME (I've not seen a definitive case though have seen 
> an OOME around time of a reconstructionlog replay -- perhaps this the straw 
> that broke the fleas antlers?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to