[
https://issues.apache.org/jira/browse/HBASE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879155#action_12879155
]
HBase Review Board commented on HBASE-2670:
-------------------------------------------
Message from: "Todd Lipcon" <[email protected]>
bq. On 2010-06-15 15:03:40, stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/KeyValue.java, line 558
bq. > <http://review.hbase.org/r/180/diff/1/?file=1345#file1345line558>
bq. >
bq. > Is this going to be correct always? Cloning, we don't want the src
memstoreTS?
yea, this clone is necessary so that incrementColumnValue() doesn't blow up to
create a new memstore entry for every increment. We could put it in that code,
but I think it's cleaner to just be part of clone. I think it's best in clone
so that a foo.compareTo(foo.clone()) == 0 as an invariant.
bq. On 2010-06-15 15:03:40, stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/KeyValue.java, line 1306
bq. > <http://review.hbase.org/r/180/diff/1/?file=1345#file1345line1306>
bq. >
bq. > What we going to do about N versions all of same r/f/q/ts but of
different memstoreTS? We're not going to suppress them just yet? We're going
to punt till hbase-1485? The multiple versions make it out to store files too?
Yea, leaving that off since the problem already exists and it's a bit of a
heavy change.
bq. On 2010-06-15 15:03:40, stack wrote:
bq. > src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java, line 140
bq. > <http://review.hbase.org/r/180/diff/1/?file=1348#file1348line140>
bq. >
bq. > Prefix w/ 'TODO' to make this work-to-do more findable.
ah, I mean that we don't need to verify at this point because the writer hasn't
actually written any rows yet! will clarify
- Todd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/180/#review229
-----------------------------------------------------------
> MemStore should retain multiple KVs with the same timestamp when memstoreTS
> differs
> -----------------------------------------------------------------------------------
>
> Key: HBASE-2670
> URL: https://issues.apache.org/jira/browse/HBASE-2670
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.20.5, 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Attachments: hbase-2670.txt, hbase-2670.txt
>
>
> There appears to be a bug in HBASE-2248 as committed to trunk. See following
> failing test:
> http://hudson.zones.apache.org/hudson/job/HBase-TRUNK/1296/testReport/junit/org.apache.hadoop.hbase/TestAcidGuarantees/testAtomicity/
> Think this is the same bug we saw early on in 2248 in the 0.20 branch, looks
> like the fix didn't make it over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
