[ 
https://issues.apache.org/jira/browse/HBASE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879539#action_12879539
 ] 

HBase Review Board commented on HBASE-2725:
-------------------------------------------

Message from: [email protected]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/187/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Adds a ShutdownHook class that is package private to regionserver.  Manages the 
running of the regionserver shutdown before running the fs shutdown hook.  New 
class has a main so its easy to check stuff works against the different 
hadoops; 0.20, 0.21 and cloudera 0.20.


This addresses bug hbase-2725.
    http://issues.apache.org/jira/browse/hbase-2725


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java fe9aa8a 
  src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java 
PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/regionserver/Stoppable.java 
PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 479c661 

Diff: http://review.hbase.org/r/187/diff


Testing
-------


Thanks,

stack




> Shutdown hook management is gone in trunk; restore
> --------------------------------------------------
>
>                 Key: HBASE-2725
>                 URL: https://issues.apache.org/jira/browse/HBASE-2725
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: 2725.txt
>
>
> Shutdown hook handling is gone from trunk.  Investigate (I think I did this 
> cleaning up tests but was over-enthusiastic pruning).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to