[
https://issues.apache.org/jira/browse/HBASE-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880422#action_12880422
]
Dave Latham commented on HBASE-2752:
------------------------------------
Thanks for the quick work. It's really aprpeciated. I'll try to get this
patch tested on a cluster.
Minor nits:
* The log on "Cache flush failed" should use toStringBinary for the region name.
* blockingWaitTime / 100 seems somewhat arbitrary for check interval, but
probably fine for now.
> Don't retry forever when waiting on too many store files
> --------------------------------------------------------
>
> Key: HBASE-2752
> URL: https://issues.apache.org/jira/browse/HBASE-2752
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: stack
> Priority: Critical
> Fix For: 0.20.5, 0.21.0
>
> Attachments: 2752.txt
>
>
> HBASE-2087 introduced a way to not block all flushes when on region has too
> many store files. Unfortunately, that undid the behavior that if we waited
> for longer than 90 secs then that we would still flush the region... which
> means that when a region blocks inserts because its memstore is too big it's
> actually holding off writes for a very long time, occupying handlers, etc.
> We need to add more smarts in MemStoreFlusher so that we detect when a region
> was held up for too long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
