Stop dumping exceptions coming from ZK and do nothing about them
----------------------------------------------------------------
Key: HBASE-2791
URL: https://issues.apache.org/jira/browse/HBASE-2791
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Fix For: 0.21.0
I think this is part of the Master/ZooKeeper refactoring project but I'm
putting it up here to be sure we cover it. Currently in ZKW (and other places
around the code base) we do ZK operations and we don't really handle the
exceptions, for example in ZKW.setClusterState:
{code}
} catch (InterruptedException e) {
LOG.warn("<" + instanceName + ">" + "Failed to set state node in
ZooKeeper", e);
} catch (KeeperException e) {
if(e.code() == KeeperException.Code.NODEEXISTS) {
LOG.debug("<" + instanceName + ">" + "State node exists.");
} else {
LOG.warn("<" + instanceName + ">" + "Failed to set state node in
ZooKeeper", e);
}
{code}
This has been always like that since we started using ZK.
What if the session was expired? What if it was only the connection that had a
blip? Do we handle it correctly? We need to have this discussion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
