[
https://issues.apache.org/jira/browse/HBASE-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888839#action_12888839
]
HBase Review Board commented on HBASE-2696:
-------------------------------------------
Message from: "Jonathan Gray" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/324/
-----------------------------------------------------------
Review request for hbase, stack, Jean-Daniel Cryans, and Karthik Ranganathan.
Summary
-------
Next set of changes for ZK cleanup (following master startup cleanup in
HBASE-2695).
This completes move from ZooKeeperWrapper to ZooKeeperWatcher (and all the new
ZK bits) for the RS and Client. There is still work to do in Master, that is
next patch which hopefully comes today.
* Rename {{ServerStatus}} to {{ServerController}} (still have MasterStatus,
that will be renamed in next patch)
** Client uses this now, maybe should be ProcessController?
* Adds a new client exception {{ZooKeeperConnectionException}} which is
subclass of IOException. Thrown from HTable and HBaseAdmin if no ZK connection
* Fixes client so that it can ride over master changes
** Uses {{MasterAddressManager}} already being used on RS
** {{HBaseAdmin}} uses accessor method to get master reference rather than a
class variable
** Move all ZK interactions to go via ZKUtil/ZKWatcher not ZKWrapper
* Moves RS completely off of ZKWrapper and onto ZKUtil/ZKWatcher
* Adds lots of new methods to ZKUtil, every one with full javadoc
This addresses bug HBASE-2696.
http://issues.apache.org/jira/browse/HBASE-2696
Diffs
-----
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/ServerController.java
PRE-CREATION
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/ServerStatus.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/ZooKeeperConnectionException.java
PRE-CREATION
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/client/HTable.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/client/ServerConnectionManager.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/MasterStatus.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/regionserver/MasterAddressManager.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/regionserver/RSZookeeperUpdater.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
964096
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
964096
branches/0.90_master_rewrite/src/main/resources/hbase-webapps/master/zk.jsp
964096
branches/0.90_master_rewrite/src/main/resources/hbase-webapps/regionserver/regionserver.jsp
964096
branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
964096
branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
964096
branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
964096
branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java
964096
branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
964096
Diff: http://review.hbase.org/r/324/diff
Testing
-------
Had to fix up some of the ZK unit tests to work on new ZKUtil/ZKWatcher, all
those passing. Existing unit tests on MasterAddressManager.
Test suite seems to be passing, underway.
Thanks,
Jonathan
> ZooKeeper cleanup and refactor
> ------------------------------
>
> Key: HBASE-2696
> URL: https://issues.apache.org/jira/browse/HBASE-2696
> Project: HBase
> Issue Type: Sub-task
> Components: master, regionserver, zookeeper
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: HBASE-2696-part1-NewClasses_NotIntegrated.patch,
> HBASE-2696-part1-v2-NewClasses_NotIntegrated.patch,
> HBASE-2696-part1-v3-NewClasses_RS.patch,
> HBASE-2696-part1-v4-NewClasses_RS_Tested.patch,
> HBASE-2696-part1-v5-NewClasses_RS_Tested.patch
>
>
> Currently almost everything we do with ZooKeeper is stuffed into a single
> class {{ZookeeperWrapper}}.
> This issue will deal with cleaning up our usage of ZK, adding some new
> abstractions to help with the master changes, splitting up watchers from
> utility methods, and nailing down the contracts of our ZK methods with
> respect to setting watchers, throwing exceptions, etc...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
