[ 
https://issues.apache.org/jira/browse/HBASE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888859#action_12888859
 ] 

HBase Review Board commented on HBASE-2517:
-------------------------------------------

Message from: "Jonathan Gray" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/323/#review405
-----------------------------------------------------------

Ship it!


+1 from me as well


trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
<http://review.hbase.org/r/323/#comment1724>

    Good catch on this ordering.



trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
<http://review.hbase.org/r/323/#comment1725>

    Again, good stuff


- Jonathan





> During reads when passed the specified time range, seek to next column
> ----------------------------------------------------------------------
>
>                 Key: HBASE-2517
>                 URL: https://issues.apache.org/jira/browse/HBASE-2517
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Jonathan Gray
>            Assignee: Pranav Khaitan
>             Fix For: 0.90.0
>
>
> When we are processing the stream of KeyValues in the ScanQueryMatcher, we 
> will check the timestamp of the current KV against the specific TimeRange.  
> Currently we only check if it is in the range or not, returning SKIP if 
> outside the range or continuing to other checks if within the range.
> The check should actually return SKIP if the stamp is greater than the 
> TimeRange and NEXT_COL if the stamp is less than the TimeRange (we know we 
> won't take anymore columns from the current column once we are below the 
> TimeRange).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to