[
https://issues.apache.org/jira/browse/HBASE-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889316#action_12889316
]
HBase Review Board commented on HBASE-1511:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/328/#review414
-----------------------------------------------------------
Ship it!
This looks nice Nicolas. Want to take care of the few below and I'll then
commit?
trunk/bin/local-master-backup.sh
<http://review.hbase.org/r/328/#comment1761>
Why is it called local-master-backup? Should be a more descriptive name?
Its the 'backup' that throws me off. 'local-masters'?
trunk/bin/local-master-backup.sh
<http://review.hbase.org/r/328/#comment1762>
Explain 'offset' in this usage output? (Seems to be port offset from
default?)
trunk/bin/local-master-backup.sh
<http://review.hbase.org/r/328/#comment1763>
Isn't the master default port 60000, not 60020? 60020 is RS default port?
trunk/conf/hbase-site.xml.psuedo-distributed
<http://review.hbase.org/r/328/#comment1767>
This is commented out because dfs.support.append doesn't work with local fs?
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.hbase.org/r/328/#comment1768>
You are adding a tab here? Or white-space?
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.hbase.org/r/328/#comment1769>
Add more comment in here... in particular on the '-splitting' suffix.
Where's that come from?
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.hbase.org/r/328/#comment1770>
Tab?
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.hbase.org/r/328/#comment1772>
There is whitespace in here.
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.hbase.org/r/328/#comment1773>
Sorry Nicolas... this looks like an old unused option. Should probably
remove it.
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.hbase.org/r/328/#comment1774>
This is a nice addition.
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.hbase.org/r/328/#comment1775>
White space
- stack
> Pseudo distributed mode in LocalHBaseCluster
> --------------------------------------------
>
> Key: HBASE-1511
> URL: https://issues.apache.org/jira/browse/HBASE-1511
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.19.3
> Reporter: Evgeny Ryabitskiy
> Assignee: Nicolas Spiegelberg
> Priority: Minor
> Fix For: 0.92.0
>
>
> After changes to config and adding of parameter:
> {code}
> <property>
> <name>hbase.cluster.distributed</name>
> <value>false</value>
> <description>The mode the cluster will be in. Possible values are
> false: standalone and pseudo-distributed setups with managed Zookeeper
> true: fully-distributed with unmanaged Zookeeper Quorum (see
> hbase-env.sh)
> </description>
> </property>
> {code}
> running HBase in pseudo destr mode become not so easy, I think description
> for false variant is wrong and you can't get pseudo-distributed mode setting
> this option to false now.
> I wish to have some option in LocalHBaseCluster for pseudo destr mode where I
> wish to have:
> * separate processes for Master and HRSs
> * ability to dynamically change HRS number in cluster
> * managed ZK cluster (like it is in local mode now)
> * managed small local HDFS cluster
> I think it is very useful for testing, debugging and for user experience with
> HBase, who want to try something close to real HBase not some emulation in
> standalone mode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
