[
https://issues.apache.org/jira/browse/HBASE-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890548#action_12890548
]
HBase Review Board commented on HBASE-2858:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/349/#review435
-----------------------------------------------------------
Looks good. I'm not clear on some of below. Can you clarify before I +1 it?
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
<http://review.hbase.org/r/349/#comment1834>
Just remove this method altogether?
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
<http://review.hbase.org/r/349/#comment1835>
Is this right? You are getting a reader here. If file is not in expected
location, we fall into FNFE area. These just seem to be testing existance, not
getting a reader on the new location if it exists.
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
<http://review.hbase.org/r/349/#comment1836>
See above comment on this same method.
- stack
> TestReplication.queueFailover fails half the time
> -------------------------------------------------
>
> Key: HBASE-2858
> URL: https://issues.apache.org/jira/browse/HBASE-2858
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.0
>
>
> TestReplication.queueFailover fails 50% of the time, it's because
> ZooKeeperWrapper.listZnodes (introduced in HBASE-2694 and missed by
> HBASE-2735) doesn't use the Watcher it's passed so sometimes
> ReplicationSource misses hlogs to replicate for the region server we kill.
> Also it uncovered an issue (while I was fixing the first one) that RepSource
> ignores log files too quickly when the master is a bit too slow to split logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
