[
https://issues.apache.org/jira/browse/HBASE-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891487#action_12891487
]
HBase Review Board commented on HBASE-1537:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/376/#review463
-----------------------------------------------------------
Ship it!
+1 on commit. Suggestion on how to make some minor savings. Go ahead and
commit with if it makes sense to you (or do w/o the suggestion).
src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
<http://review.hbase.org/r/376/#comment1902>
Consider using method Ryan added today:
public boolean matchingRows(final KeyValue left, final byte [] right) {
Then you could do if (!KeyValue.matchingRows(matcher.row, peeked)
.. and only do a peeked.getRow when you know you've changed rows..
Might same a bit of byte array making.
- stack
> Intra-row scanning
> ------------------
>
> Key: HBASE-1537
> URL: https://issues.apache.org/jira/browse/HBASE-1537
> Project: HBase
> Issue Type: New Feature
> Reporter: Jonathan Gray
> Assignee: Andrew Purtell
> Fix For: 0.90.0
>
> Attachments: HBASE-1537-2.patch, HBASE-1537-v1.patch,
> HBASE-1537-v2-0.20.3.patch, HBASE-1537-v2.patch
>
>
> To continue scaling numbers of columns or versions in a single row, we need a
> mechanism to scan within a row so we can return some columns at a time.
> Currently, an entire row must come back as one piece.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
