[
https://issues.apache.org/jira/browse/HBASE-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893758#action_12893758
]
HBase Review Board commented on HBASE-2823:
-------------------------------------------
Message from: "Nicolas" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/426/#review577
-----------------------------------------------------------
Ship it!
looks good
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
<http://review.cloudera.org/r/426/#comment2220>
inverted logic not necessary here. it might be more straightforward to say:
if(type == ROWCOL) {
// comments + special stuff
} else {
// normal stuff.
}
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
<http://review.cloudera.org/r/426/#comment2219>
small typo: s/and/an/
- Nicolas
> Entire Row Deletes not stored in Row+Col Bloom
> ----------------------------------------------
>
> Key: HBASE-2823
> URL: https://issues.apache.org/jira/browse/HBASE-2823
> Project: HBase
> Issue Type: Bug
> Components: filters, regionserver
> Affects Versions: 0.90.0
> Reporter: Nicolas Spiegelberg
> Assignee: Alexander Georgiev
> Fix For: 0.90.0
>
>
> If the user issues a Row Delete on an family with Row+Col blooms, that
> information is not currently detected by shouldSeek(). Possible known
> solutions are:
> 1. adding Row as Bloom Filter Key on Row Delete, shouldSeek() should do both
> a Row & Row+Col query for Row+Col filters.
> 2. keep delete information in a separate storage element.
> #1 seems like the best solution, but need to investigate further and fix this
> problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
