[
https://issues.apache.org/jira/browse/HBASE-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893885#action_12893885
]
HBase Review Board commented on HBASE-2890:
-------------------------------------------
Message from: "Gary Helmling" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/442/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Simple change to initialize RPC metrics based on methods declared in RPC
protocol interfaces: HMasterInterface, HMasterRegionInterface, HRegionInterface.
This addresses bug HBASE-2890.
http://issues.apache.org/jira/browse/HBASE-2890
Diffs
-----
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java d88c12d
Diff: http://review.cloudera.org/r/442/diff
Testing
-------
Thanks,
Gary
> Initialize RPC JMX metrics on startup
> -------------------------------------
>
> Key: HBASE-2890
> URL: https://issues.apache.org/jira/browse/HBASE-2890
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.90.0
>
>
> Currently RPC call metrics are created dynamically based on cluster activity.
> So when monitoring via JMX, not all RPC statistics may be present in the
> exported MBean, depending on what the past cluster activity has been.
> HBASE-2146 has previously added code to initialize the MBean attributes on
> startup for all RPC methods, but in a way that depended on the defunct code
> -> method name mappings.
> This issue is to initialize the exported MBean attributes in a cleaner way,
> by introspecting the RPC protocol interfaces (HMasterInterface,
> HMasterRegionInterface, HRegionInterface).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
