[ 
https://issues.apache.org/jira/browse/HBASE-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894813#action_12894813
 ] 

stack commented on HBASE-2871:
------------------------------

Good stuff N.  Thanks for doing this.

On bringing environment variables into stop-hbase.sh, could these instead be 
kept out in hbase-env.sh?  Isn't that sourced by this stop-hbase script?

Let me know what you think on above.

(On commit, I'll go over the doc. to make sure we change how shutdown is done 
-- I'll do that, don't worry about it).

> Make "start|stop" commands symmetric for Master & Cluster
> ---------------------------------------------------------
>
>                 Key: HBASE-2871
>                 URL: https://issues.apache.org/jira/browse/HBASE-2871
>             Project: HBase
>          Issue Type: Improvement
>          Components: scripts
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Trivial
>             Fix For: 0.90.0
>
>         Attachments: HBASE-2871.patch
>
>
> Currently, our master & server start/stop commands aren't asymmetric.  
> Calling "hbase-daemon.sh start master" will create a single Master process, 
> but calling "hbase-daemon.sh stop master" will stop the master + 
> regionservers.  Additionally, running bin/stop-hbase.sh will not work 
> properly if a backup master is currently the primary.  We should modify these 
> commands so they are intuitive/asymmetric and let the HBase contributors 
> (instead of users) live with the fact that it might be a little ugly 
> underneath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to