[
https://issues.apache.org/jira/browse/HBASE-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895542#action_12895542
]
HBase Review Board commented on HBASE-2844:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/334/#review678
-----------------------------------------------------------
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServer.java
<http://review.cloudera.org/r/334/#comment2466>
Should we even include this test Pranav? I don't see where you are proving
that we do not exceed the limit or that the limit works. Also, where are you
making the splits in this test?
I'm fine committing the patch without this test -- the code as is looks
fine to me.
- stack
> Capping the number of regions
> -----------------------------
>
> Key: HBASE-2844
> URL: https://issues.apache.org/jira/browse/HBASE-2844
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
> Priority: Minor
>
> It may sometimes be advantageous to prevent the number of regions from
> growing very large. This may happen if the values are large in size even
> though the number of keyvalues are not large. If the number of regions
> becomes too large, then it is difficult to accommodate the memstore for each
> region in memory. In such cases, we either have to flush out memstore to disk
> or decrease size of each memstore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
