[ 
https://issues.apache.org/jira/browse/HBASE-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896788#action_12896788
 ] 

HBase Review Board commented on HBASE-2870:
-------------------------------------------

Message from: "Nicolas" <[email protected]>


bq.  On 2010-08-09 20:33:12, stack wrote:
bq.  > I applied patch and built.  On shutdown of a standalone instance I got 
this:
bq.  > 
bq.  > "pynchon-305:trunk stack$ ./bin/stop-hbase.sh 
bq.  > stopping 
hbase................../Users/stack/checkouts/trunk/bin/hbase-daemons.sh: line 
49: /Users/stack/checkouts/trunk/bin/master-backup.sh: Permission denied
bq.  > /Users/stack/checkouts/trunk/bin/hbase-daemons.sh: line 49: exec: 
/Users/stack/checkouts/trunk/bin/master-backup.sh: cannot execute: Unknown 
error: 0"
bq.  > 
bq.  > My script looks to have x perms:
bq.  > 
bq.  > pynchon-305:trunk stack$ ls -la bin/hbase-daemons.sh 
bq.  > -rwxr-xr-x  1 stack  staff  1628 Aug  9 20:21 bin/hbase-daemons.sh
bq.  > 
bq.  > The passed 'args' are bad for standalone?

'conf/backup-masters' are not meant to be local instances, just like extra 
regionservers aren't.  Hence bin/local-master-backup.sh & 
bin/local-regionserver.sh (trying to stay consistent).  However, I didn't 
originally test this in local mode, only a cluster.  Tested in local mode and 
got the same error.  I ran 'chmod +x bin/master-backup.sh' and the problem went 
away.  Let me know if you still have problems.  Should run fine other than 
that.  

I did notice that I need to place 'stop master-backup' inside the distributed 
conditional.  Will fix on the next update.


bq.  On 2010-08-09 20:33:12, stack wrote:
bq.  > trunk/bin/master-backup.sh, line 64
bq.  > <http://review.cloudera.org/r/592/diff/1/?file=6096#file6096line64>
bq.  >
bq.  >     I don't understand this construct Nicolas (My shell scripting 
requires me to have a book or a web page open while I write -- currently its 
not present).

this performs string substitution on ${args} and changes 'master-backup' to 
'master'.  The remote command to call is 'hbase-daemon.sh start master 
--backup'.  I'm changing to ${args/master-backup/master} for a little more 
clarity


- Nicolas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/592/#review793
-----------------------------------------------------------





> Add Backup CLI Option to HMaster
> --------------------------------
>
>                 Key: HBASE-2870
>                 URL: https://issues.apache.org/jira/browse/HBASE-2870
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Nicolas Spiegelberg
>            Assignee: Karthik Ranganathan
>            Priority: Minor
>             Fix For: 0.90.0
>
>
> The HMaster main() should allow a toggle like --backup, which forces it to be 
> a secondary master on startup versus a primary candidate.  That way, we can 
> start up multiple masters at once and deterministically know which one will 
> be the original primary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to