SequenceFileLogWriter doesnt make it clear if there is no append by config or
by missing lib/feature
----------------------------------------------------------------------------------------------------
Key: HBASE-2918
URL: https://issues.apache.org/jira/browse/HBASE-2918
Project: HBase
Issue Type: Bug
Affects Versions: 0.89.20100621
Reporter: ryan rawson
Priority: Minor
Fix For: 0.90.0
This code doesnt make the situation clear:
Method m = null;
if (conf.getBoolean("dfs.support.append", false)) {
try {
// function pointer to writer.syncFs()
m = this.writer.getClass().getMethod("syncFs", new Class<?> []{});
} catch (SecurityException e) {
throw new IOException("Failed test for syncfs", e);
} catch (NoSuchMethodException e) {
// Not available
}
}
this.syncFs = m;
LOG.info((this.syncFs != null)?
"Using syncFs -- HDFS-200": "syncFs -- HDFS-200 -- not available");
we dont know if the test failed, or if the config is turned off. it would make
debuggers life easier if the message was clearer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
