[
https://issues.apache.org/jira/browse/HBASE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900060#action_12900060
]
HBase Review Board commented on HBASE-2928:
-------------------------------------------
Message from: "Pranav Khaitan" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/686/
-----------------------------------------------------------
(Updated 2010-08-18 14:46:42.108879)
Review request for hbase and Jonathan Gray.
Summary
-------
Following statement makes an incorrect assumption that value.length >=
this.value.length.
return Bytes.compareTo(this.value, 0, this.value.length, value, 0,
this.value.length);
(Also, removed a couple of unused imports)
This addresses bug HBASE-2928.
http://issues.apache.org/jira/browse/HBASE-2928
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/filter/BinaryPrefixComparator.java
986945
trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java
986945
Diff: http://review.cloudera.org/r/686/diff
Testing (updated)
-------
All tests based on PrefixFilter run successfully.
Thanks,
Pranav
> Fault in logic in BinaryPrefixComparator leads to
> ArrayIndexOutOfBoundsException.
> ---------------------------------------------------------------------------------
>
> Key: HBASE-2928
> URL: https://issues.apache.org/jira/browse/HBASE-2928
> Project: HBase
> Issue Type: Bug
> Components: filters
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
>
> Following statement makes an incorrect assumption that value.length >=
> this.value.length.
> return Bytes.compareTo(this.value, 0, this.value.length, value, 0,
> this.value.length);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
