[ 
https://issues.apache.org/jira/browse/HBASE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906301#action_12906301
 ] 

stack commented on HBASE-2962:
------------------------------

+1 on removing from HTable, replacing the javadoc w/ @Override, and putting the 
javadoc into HTableInterface.  If @Override, eclipse at least will complain if 
nothing overridden and will underline the fact that there is an HTableInterface 
to consider.

Thanks for doing this Lars.

> Add missing methods to HTableInterface (and HTable)
> ---------------------------------------------------
>
>                 Key: HBASE-2962
>                 URL: https://issues.apache.org/jira/browse/HBASE-2962
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>            Reporter: Lars Francke
>             Fix For: 0.90.0
>
>         Attachments: HBASE-2962.1.diff
>
>
> HBASE-1845 added two new methods in HTable (batch). Those need to be in 
> HTableInterface as well.
> And in HTable we have:
> * put(Put)
> * put(List<Put>)
> * delete(Delete)
> * delete(List<Delete>)
> * get(Get)
> Shouldn't we add a get(List<Get>) as well for consistency?
> Others that are missing:
> * getRegionLocation
> * getScannerCaching / setgetScannerCaching
> * getStartKeys / getEndKeys / getStartEndKeys
> * getRegionsInfo
> * setAutoFlush
> * getWriteBufferSize / setWriteBufferSize
> * getWriteBuffer
> * prewarmRegionCache
> * serializeRegionInfo / deserializeRegionInfo
> For some of those it might not make sense to add them. I'm just listing them 
> all.
> The patch is trivial once we've decided which to add, I'll prepare one for 
> batch & get.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to