[
https://issues.apache.org/jira/browse/HBASE-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908872#action_12908872
]
HBase Review Board commented on HBASE-2988:
-------------------------------------------
Message from: "Todd Lipcon" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/821/#review1163
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
<http://review.cloudera.org/r/821/#comment4000>
This will throw NPE if it's not set, right?
Why not just make this return getCompression() if n == null, then you can
get rid of the hasCompactionCompression() check down in StoreFile below and
simplify things a bit?
Also why redundant getCompactionCompression and
getCompactionCompressionType?
- Todd
> Support alternate compression for major compactions
> ---------------------------------------------------
>
> Key: HBASE-2988
> URL: https://issues.apache.org/jira/browse/HBASE-2988
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Minor
> Attachments: HBASE-2988-0.20.patch, HBASE-2988-trunk.patch
>
>
> Support an alternate compression scheme on HFiles during major compaction.
> See discussion on HBASE-2987 for background.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
