[
https://issues.apache.org/jira/browse/HBASE-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909536#action_12909536
]
HBase Review Board commented on HBASE-2941:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/846/#review1213
-----------------------------------------------------------
Looks good. Do the RPC tests pass? There are a few small things below.
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<http://review.cloudera.org/r/846/#comment4124>
What happens now if key is not acceptable?
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<http://review.cloudera.org/r/846/#comment4125>
Now we let the IE out?
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<http://review.cloudera.org/r/846/#comment4126>
No need of the limit of ten anymore because pool is bounded?
- stack
> port HADOOP-6713 - threading scalability for RPC reads - to HBase
> -----------------------------------------------------------------
>
> Key: HBASE-2941
> URL: https://issues.apache.org/jira/browse/HBASE-2941
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.20.6, 0.89.20100621
> Reporter: ryan rawson
> Assignee: ryan rawson
> Fix For: 0.90.0
>
> Attachments: HBASE-2941.patch, HBASE-2941.txt, HBASE-2941.xlsx,
> HBaseServer.java, Rplot001.png
>
>
> HADOOP-6713 has patch to fix the read scalability of hadoop rpc. Right now
> a single thread accepts() then receives the RPC payload for every single RPC
> in hbase. Including object creation, writable deserialization, etc.
> Apply the patch from that issue to our own forked HBaseRPC code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
