[
https://issues.apache.org/jira/browse/HBASE-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916666#action_12916666
]
HBase Review Board commented on HBASE-3058:
-------------------------------------------
Message from: "Jonathan Gray" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/927/
-----------------------------------------------------------
(Updated 2010-09-30 13:50:57.922028)
Review request for hbase, stack and Andrew Purtell.
Changes
-------
Much simpler patch. REST tests passing.
Summary
-------
This method adds Configuration as a parameter to almost all the rest classes.
This is because they all extend a base class, ResourceBase, which just holds a
reference to a single RESTServlet that gets instantiated as a singleton. It's
this RESTServlet which needs to take a Configuration. Since ResourceBase is
instantiated all over the place, everything needs Configuration.
This doesn't work though. Most of these classes get instantiated through
REST/JAX automagic, so it's getting null Configuration.
Could use some help.
This addresses bug HBASE-3058.
http://issues.apache.org/jira/browse/HBASE-3058
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java 1003250
trunk/src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTClusterTestBase.java
1003206
Diff: http://review.cloudera.org/r/927/diff
Testing
-------
REST tests failing now with NPE because everything gets null Configuration
objects. Without patch they fail because they try to contact the wrong master.
Thanks,
Jonathan
> Fix REST tests on trunk
> -----------------------
>
> Key: HBASE-3058
> URL: https://issues.apache.org/jira/browse/HBASE-3058
> Project: HBase
> Issue Type: Bug
> Components: rest
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: HBASE-3058-v3.patch
>
>
> Most of the REST tests do not pass on trunk. Most likely because
> configuration is being generated internally within REST classes rather than
> being passed in, so when tests override configs they are not getting picked
> up.
> There was a similar issue already fixed with thrift and avro.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
