[ 
https://issues.apache.org/jira/browse/HBASE-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919392#action_12919392
 ] 

HBase Review Board commented on HBASE-2579:
-------------------------------------------

Message from: [email protected]


bq.  On 2010-05-25 12:32:28, Todd Lipcon wrote:
bq.  > Looks pretty good. The one thing I don't like is that checkAndMutate 
takes a Writable, and then downcasts based on instanceof. Can we extract a 
common interface between Put and Delete? maybe something like RowMutation or 
RowOperation, which would have getRowLock and a "performMutation()" or 
something? What do you guys think?
bq.  
bq.  Ryan Rawson wrote:
bq.      I think we should address that in a different JIRA, just because its 
more of an API design.  This is one more API endpoint and that is more of a 
refactor.
bq.  
bq.  Todd Lipcon wrote:
bq.      Fair enough

So, is this ready for commit? (we can address Todd comments on commit).  I can 
make an issue for common interface across Delete/Put.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/84/#review54
-----------------------------------------------------------





> Add atomic checkAndDelete support
> ---------------------------------
>
>                 Key: HBASE-2579
>                 URL: https://issues.apache.org/jira/browse/HBASE-2579
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Michael Dalton
>             Fix For: 0.90.0
>
>         Attachments: 2579-v2.patch, 2579.patch
>
>
> Currently HBase has support for atomic checkAndPut operations on individual 
> rows. It would be very useful to also support atomic checkAndDelete. I have 
> added support for atomic checkAndDelete to trunk and will provide the 
> corresponding patch tonight after I merge in any upstream changes from the 
> last few days.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to