[
https://issues.apache.org/jira/browse/HBASE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-3100:
-------------------------
Attachment: 3100.txt
Here's a patch. I rewrote TestMergeTable so it should now be intelligible.
Also added assertions that its actually doing a merge. Patch also does some
cleanup of old unused super class and a test that did nothing.
{code}
M src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
Some fixup to support stepped start up of mini cluster; allow
starting dfs cluster, then later put an hbase mini cluster on top.
(startMiniHBaseCluster, createRootDir): Added.
D src/test/java/org/apache/hadoop/hbase/AbstractMergeTestBase.java
Removed messy subclass of HBaseClusterTestCase used building
up some specific loaded regions. Replaced with utility added
to HBaseTestingUtility and by methods added to specific test.
D src/test/java/org/apache/hadoop/hbase/util/TestMergeMeta.java
Deleted test that did nothing -- test merging of .META. -- but
the superclass was making user regions, not multiple instances
of .META. -- which we don't support anyways currently.
M src/test/java/org/apache/hadoop/hbase/util/TestMergeTable.java
Rewritten to use HBaseTestingUtility. Also added assertions that
it actually did successful merge (Were none previous).
M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
Added a new constructor. Are the others redundant given I just
added implementation of Abortable to HConnection interface (the
implmementation of HConnection used implement it -- I've just
moved it up into the Interface itself).
M src/main/java/org/apache/hadoop/hbase/util/HMerge.java
Bit of minor cleanup refactoring.
M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
The HConnection Interface now implements Abortable.
M src/main/java/org/apache/hadoop/hbase/client/HConnection.java
Extend Abortable (The implementation was implementing Abortable
anyways).
{code}
> TestMergeTable failing in TRUNK
> -------------------------------
>
> Key: HBASE-3100
> URL: https://issues.apache.org/jira/browse/HBASE-3100
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.90.0
>
> Attachments: 3100.txt
>
>
> This is an old crufty test that is failing in TRUNK. We create regions --
> user, root, and meta regions offline -- but then come along and disable them
> after starting up minicluster. Confuses new master. This test also does not
> emit logging up in hudson because its written against old-style testing...
> even has a subclass of the HBaseTestCase to do this crazy manual creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
