[ 
https://issues.apache.org/jira/browse/HBASE-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922713#action_12922713
 ] 

Nicolas Spiegelberg commented on HBASE-3102:
--------------------------------------------

The MetricsTimeVaryingRate introspection is primarily in 
MetricsDynamicMBeanBase.java, so that would need to be hand-rolled for a custom 
class.  All the class variables in MetricsTimeVaryingRate are private (at 
least, in 0.20), so there is no way to usefully subclass without nasty 
introspection.  If a completely custom class is necessary in the future, a 
refactoring jira can be created later :)

I think most of these optimizations / refactoring would be good for a separate 
jira.  We don't need that level of granularity for polling periods, so I think 
it's best to wait until someone needs that requirement.

> Enhance HRegionServerMetrics for Long-running Stats
> ---------------------------------------------------
>
>                 Key: HBASE-3102
>                 URL: https://issues.apache.org/jira/browse/HBASE-3102
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>             Fix For: 0.90.0
>
>         Attachments: HBASE-3102_90.patch
>
>
> A useful metric to observe track is compaction count + duration. Since 
> compactions are long running and only happen infrequently, the avg/opcount 
> stats are should be reset longer than the default polling period (5 sec). In 
> addition to 'hbase.period', we should allow a different duration after which 
> long-running metrics should expire. This would also fix our existing metrics 
> problem where min/max stats are never reset until the process is 
> restarted/upgraded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to