[
https://issues.apache.org/jira/browse/HBASE-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923132#action_12923132
]
HBase Review Board commented on HBASE-3082:
-------------------------------------------
Message from: "Benoit Sigoure" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1053/#review1586
-----------------------------------------------------------
Just some minor comments.
src/main/java/org/apache/hadoop/hbase/regionserver/ControlledScan.java
<http://review.cloudera.org/r/1053/#comment5387>
This class doesn't need to be public, make it package-private.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/1053/#comment5389>
The style used in HBase mandates that this method be named getLastIncrement.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/1053/#comment5388>
A `//'-style comment would be better here
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.cloudera.org/r/1053/#comment5390>
use if (!results.isEmpty())
src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
<http://review.cloudera.org/r/1053/#comment5391>
Instead of two nested `if', you could combine both conditions with `&&'
- Benoit
> For ICV gets, first look in MemStore before reading StoreFiles
> --------------------------------------------------------------
>
> Key: HBASE-3082
> URL: https://issues.apache.org/jira/browse/HBASE-3082
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Jonathan Gray
> Assignee: Prakash Khemani
>
> For incrementColumnValue operations, it is possible to check MemStore for the
> column being incremented without sacrificing correctness. If the column is
> not found in MemStore, we would then have to do a normal Get that
> opens/checks all StoreFiles for the given Store.
> In practice, this makes increment operations significantly faster for
> recently/frequently incremented columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
