[ 
https://issues.apache.org/jira/browse/HBASE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925938#action_12925938
 ] 

HBase Review Board commented on HBASE-3165:
-------------------------------------------

Message from: "Ryan Rawson" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1109/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

HBASE-3165


This addresses bug HBASE-3165.
    http://issues.apache.org/jira/browse/HBASE-3165


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/client/Result.java e0307ca 
  src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 83f623d 
  src/main/java/org/apache/hadoop/hbase/io/WritableWithSize.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/ipc/ByteBufferOutputStream.java 
PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java e4c356d 

Diff: http://review.cloudera.org/r/1109/diff


Testing
-------


Thanks,

Ryan




> some performance things i did
> -----------------------------
>
>                 Key: HBASE-3165
>                 URL: https://issues.apache.org/jira/browse/HBASE-3165
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>         Attachments: HBASE-2165-2.txt, HBASE-2165.txt
>
>
> in an attempt to improve the profile of the serialization of results in the 
> regionserver side I did a large number of things to reduce buffer copies, 
> improve the API usage efficiency (using the BB API directly) and so on.
> Using a YCSB config like so:
> recordcount=10000
> #recordcount=5
> operationcount=1000
> workload=com.yahoo.ycsb.workloads.CoreWorkload
> readallfields=true
> readproportion=0
> updateproportion=0
> scanproportion=1
> insertproportion=0
> fieldlength=10
> fieldcount=100
> requestdistribution=zipfian
> scanlength=300
> scanlengthdistribution=zipfian
> threadcount=1
> columnfamily=data
> Doing a medium sized scan of 1-300 rows.
> Top line performance was at about 67ms, but these micro improvements didnt 
> budge that needle, and it didnt change the scale of the CPU profiler - ie: 
> cpu time spent in serialization was the same.
> Since then I also made an improvement to HBase-YCSB which may have been 
> masking the performance gains.  I have suspended this work in favor of 0.90 
> pre-release work for now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to