[
https://issues.apache.org/jira/browse/HBASE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929824#action_12929824
]
HBase Review Board commented on HBASE-3208:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1188/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
This patch simply adds the "<=" in findMemstoresWithEditsOlderThan, renames it
to findMemstoresWithEditsEqualOrOlderThan, and fixes the unit tests.
This addresses bug HBASE-3208.
http://issues.apache.org/jira/browse/HBASE-3208
Diffs
-----
/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
1032760
/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
1032760
Diff: http://review.cloudera.org/r/1188/diff
Testing
-------
Thanks,
Jean-Daniel
> HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal
> to too
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3208
> URL: https://issues.apache.org/jira/browse/HBASE-3208
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.90.0
>
>
> Follow up to HBASE-3198, now that we are doing the right thing it seems that
> TestWALObserver is throwing NPEs. Digging in more, I figured that
> HLog.findMemstoresWithEditsOlderThan actually needs to be looking at edits
> that are equal or older rather than just older since logs with only 1 edit
> won't get any regions to flush.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
