[ 
https://issues.apache.org/jira/browse/HBASE-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930352#action_12930352
 ] 

HBase Review Board commented on HBASE-3209:
-------------------------------------------

Message from: "Nicolas" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1192/#review1878
-----------------------------------------------------------



trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.cloudera.org/r/1192/#comment6095>

    I know.  I'm a whitespace ASBO.  sorry :(



trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.cloudera.org/r/1192/#comment6092>

    we can work on fine-tuning this.  +50% was a safe cover for us and worked 
fine because we pre-split regions.  Really, you probably don't need the pad 
because the summation algorithm will operate on at least 3 storefiles, so 
(assuming roughly even flush sizes) you get +100% pad from that.



trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.cloudera.org/r/1192/#comment6091>

    s/are meet/have met/


- Nicolas





> New Compaction Heuristic
> ------------------------
>
>                 Key: HBASE-3209
>                 URL: https://issues.apache.org/jira/browse/HBASE-3209
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>
> We have a whole bunch of compaction awesome in our internal 0.89 branch.  
> Porting this to 0.90:
> 1) don't unconditionally compact 4 files. have a min threshold
> 2) intelligently upgrade minors to majors
> 3) new compaction algo (derived in HBASE-2462 )

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to