[
https://issues.apache.org/jira/browse/HBASE-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930391#action_12930391
]
HBase Review Board commented on HBASE-3168:
-------------------------------------------
Message from: [email protected]
bq. On 2010-11-09 16:40:02, stack wrote:
bq. >
trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java,
line 48
bq. > <http://review.cloudera.org/r/1193/diff/1/?file=17082#file17082line48>
bq. >
bq. > White space
I'm +1 on commit. Sounds like you found an issue where ClockSkewSync exception
is wrapped in a RemoteException... good one.
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1193/#review1883
-----------------------------------------------------------
> Sanity date and time check when a region server joins the cluster
> -----------------------------------------------------------------
>
> Key: HBASE-3168
> URL: https://issues.apache.org/jira/browse/HBASE-3168
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.89.20100924
> Environment: RHEL 5.5 64bit, 1 Master 4 Region Servers
> Reporter: Jeff Whiting
> Assignee: Jeff Whiting
> Fix For: 0.90.0
>
> Attachments: HBASE-3168-trunk-v1.txt, HBASE-3168-trunk-v2.txt,
> HBASE-3168-trunk-v3.txt, HBASE-3168-v4.patch
>
>
> Introduce a sanity check when a RS joins the cluster to make sure its clock
> isn't too far out of skew with the rest of the cluster. If the RS's time is
> too far out of skew then the master would prevent it from joining and RS
> would die and log the error.
> Having a RS with even small differences in time can cause huge problems due
> to how bhase stores values with timestamps.
> According to J-D in ServerManager we are already doing:
> {code}
> HServerInfo info = new HServerInfo(serverInfo);
> checkIsDead(info.getServerName(), "STARTUP");
> checkAlreadySameHostPort(info);
> recordNewServer(info, false, null);
> {code}
> And that the new check would fit in nicely there.
> JG suggests we add a "ClockOutOfSync-like exception"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
