[ 
https://issues.apache.org/jira/browse/HBASE-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931217#action_12931217
 ] 

Todd Lipcon commented on HBASE-2467:
------------------------------------

The only potential issue I'm aware of is this possible case where HBase will 
call hflush() on a closed stream... maybe that problem is gone in the most 
recent iteration of this patch. JD, have you seen that come up on recent 
versions? I think we can look carefully through the HBase side to see if this 
race still exists -- it was happening when the log rolled in between the append 
and hflush. We may need an rwlock to protect log rolling.

> Concurrent flushers in HLog sync using HDFS-895
> -----------------------------------------------
>
>                 Key: HBASE-2467
>                 URL: https://issues.apache.org/jira/browse/HBASE-2467
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.90.0
>
>         Attachments: HBASE-2467-v2.patch, HBASE-2467-v3.patch, 
> HBASE-2467-v4.patch, hbase-2467.txt
>
>
> HDFS-895 changes hflush() to be able to run concurrently from multiple 
> threads, where flushes can be concurrent with further writes to the same file.
> We need to rip out/amend the group commit code a bit to take advantage of 
> this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to