[ 
https://issues.apache.org/jira/browse/HBASE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931967#action_12931967
 ] 

HBase Review Board commented on HBASE-3232:
-------------------------------------------

Message from: "Ryan Rawson" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1213/#review1922
-----------------------------------------------------------


looks great, i just committed it

- Ryan





> Fix KeyOnlyFilter + Add Value Length
> ------------------------------------
>
>                 Key: HBASE-3232
>                 URL: https://issues.apache.org/jira/browse/HBASE-3232
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Blocker
>             Fix For: 0.90.0
>
>
> HBASE-3211 altered filter code to mutate KeyValues.  What could go wrong?  
> Well, your scan could mess up because the KVHeap compare functions don't work 
> properly.  If we're going to soft mutate KVs in filter code, we also need to 
> soft copy the KV before filtering.  This was found while adding the ability 
> to have KeyOnlyFilter have the option to return the Value's length.  This is 
> useful for grouping your reduce tasks into equal-sized blocks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to