[
https://issues.apache.org/jira/browse/HBASE-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932292#action_12932292
]
HBase Review Board commented on HBASE-2001:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/876/#review1930
-----------------------------------------------------------
Ship it!
+1 on commit to TRUNK. I think all below can be cleaned up on commit (Andrew,
you going to commit?)
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.cloudera.org/r/876/#comment6139>
Check in here. Looks like tabs? review board reporting it as whitespace.
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.cloudera.org/r/876/#comment6140>
Usually in hbase code base there are spaces around operations; e.g. around
'+'.
src/main/java/org/apache/hadoop/hbase/client/coprocessor/ExecResult.java
<http://review.cloudera.org/r/876/#comment6142>
Be careful. In hbase lines are 80 characters long normally. Fix on commit?
src/main/java/org/apache/hadoop/hbase/client/coprocessor/ExecResult.java
<http://review.cloudera.org/r/876/#comment6143>
I think its ok if these lines > 80 characters
src/main/java/org/apache/hadoop/hbase/client/coprocessor/package-info.java
<http://review.cloudera.org/r/876/#comment6144>
Excellent
src/main/java/org/apache/hadoop/hbase/coprocessor/package-info.java
<http://review.cloudera.org/r/876/#comment6146>
Lots of white space in here.
- stack
> Coprocessors: Colocate user code with regions
> ---------------------------------------------
>
> Key: HBASE-2001
> URL: https://issues.apache.org/jira/browse/HBASE-2001
> Project: HBase
> Issue Type: Sub-task
> Reporter: Andrew Purtell
> Assignee: Mingjie Lai
> Fix For: 0.92.0
>
> Attachments: asm-transformations.pdf,
> HBASE-2001-RegionObserver-2.patch, HBASE-2001-RegionObserver.patch,
> HBASE-2001.patch.gz, packge-info.html, packge-info.html, packge-info.html
>
>
> Support user code that runs run next to each region in table. As regions
> split and move, coprocessor code should automatically move also.
> Use classloader which looks on HDFS.
> Associate a list of classes to load with each table. Put this in HRI so it
> inherits from table but can be changed on a per region basis (so then those
> region specific changes can inherited by daughters).
> Not completely arbitrary code, should require implementation of an interface
> with callbacks for:
> * Open
> * Close
> * Split
> * Compact
> * (Multi)get and scanner next()
> * (Multi)put
> * (Multi)delete
> Add method to HTableInterface for invoking coprocessor methods and retrieving
> results.
> Add methods in o.a.h.h.regionserver or subpackage which implement convenience
> functions for coprocessor methods and consistent/controlled access to
> internals: store access, threading, persistent and ephemeral state, scratch
> storage, etc.
> GitHub: https://github.com/trendmicro/hbase/tree/coprocessor
> Please see the latest attached package-info.html for updated description.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
