[
https://issues.apache.org/jira/browse/HBASE-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935598#action_12935598
]
HBase Review Board commented on HBASE-3267:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1250/
-----------------------------------------------------------
(Updated 2010-11-24 16:44:36.709870)
Review request for hbase and Jonathan Gray.
Changes
-------
Addresses Jon' commments mostly by way of bulking up help in shell with
warnings and pulling into HBA the javadoc that was out on the HMasterInterface.
Also did stuff like make assign and unassign symmetric both taking a force
param.
Summary
-------
So, things are different in the new master. Close region should close region.
Not close and then reopen. To close and reopen elsewhere, thats an unassign or
a move (both of which were missing from shell but which are added in this
patch). I fixed the close so that its a close that does not touch zk... the
region is just closed on the regionserver. No going to zk makes it so the
close no longer makes for complaint. Close is dangerous though in that the
region is now permanently offline (I updated the close help to explain this is
so). To address it being permanently offline, I added a new assign to the
shell.
While in here, I removed commands that no longer make senses such as
enable_region and disable_region.
M src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Change move implementation so can pass an empty host.
Empty host means move to random location rather than
explicit server.
Added assign, unassign
M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
(clearRegionPlan): Added.
M src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
Improved move javadoc. Added assign, unassign.
M src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
Improved javadoc. Added assign and unassign.
M src/main/ruby/hbase/admin.rb
Added balancer, balance_switch, assign, unassign, removed
zk, enable_region and disable_region (the latter make no sense
anymore now disable/enable is done differently).
D src/main/ruby/shell/commands/zk.rb
A src/main/ruby/shell/commands/assign.rb
A src/main/ruby/shell/commands/balance_switch.rb
D src/main/ruby/shell/commands/disable_region.rb
A src/main/ruby/shell/commands/balancer.rb
A src/main/ruby/shell/commands/unassign.rb
D src/main/ruby/shell/commands/enable_region.rb
A src/main/ruby/shell/commands/move.rb
M src/main/ruby/shell/commands/close_region.rb
Fixed up help
M src/main/ruby/shell.rb
Added and removed commands.
This addresses bug hbase-3267.
http://issues.apache.org/jira/browse/hbase-3267
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1038878
trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1038878
trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
1038878
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1038878
trunk/src/main/ruby/hbase/admin.rb 1038878
trunk/src/main/ruby/shell.rb 1038878
trunk/src/main/ruby/shell/commands/assign.rb PRE-CREATION
trunk/src/main/ruby/shell/commands/balance_switch.rb PRE-CREATION
trunk/src/main/ruby/shell/commands/balancer.rb PRE-CREATION
trunk/src/main/ruby/shell/commands/close_region.rb 1038878
trunk/src/main/ruby/shell/commands/disable_region.rb 1038878
trunk/src/main/ruby/shell/commands/enable_region.rb 1038878
trunk/src/main/ruby/shell/commands/move.rb PRE-CREATION
trunk/src/main/ruby/shell/commands/unassign.rb PRE-CREATION
trunk/src/main/ruby/shell/commands/zk.rb 1038878
Diff: http://review.cloudera.org/r/1250/diff
Testing
-------
I tested shell here on my little cluster.
Thanks,
stack
> close_region shell command breaks region
> ----------------------------------------
>
> Key: HBASE-3267
> URL: https://issues.apache.org/jira/browse/HBASE-3267
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver, shell
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: stack
> Priority: Critical
> Fix For: 0.90.0
>
>
> It used to be that you could use the close_region command from the shell to
> close a region on one server and have the master reassign it elsewhere. Now
> if you close a region, you get the following errors in the master log:
> 2010-11-23 00:46:34,090 WARN
> org.apache.hadoop.hbase.master.AssignmentManager: Received CLOSING for region
> ffaa7999e909dbd6544688cc8ab303bd from server
> haus01.sf.cloudera.com,12020,1290501789693 but region was in the state null
> and not in expected PENDI
> 2010-11-23 00:46:34,530 DEBUG
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher:
> master:60000-0x12c537d84e10062 Received ZooKeeper Event,
> type=NodeDataChanged, state=SyncConnected,
> path=/hbase/unassigned/ffaa7999e909dbd6544688cc8ab303bd
> 2010-11-23 00:46:34,531 DEBUG org.apache.hadoop.hbase.zookeeper.ZKUtil:
> master:60000-0x12c537d84e10062 Retrieved 128 byte(s) of data from znode
> /hbase/unassigned/ffaa7999e909dbd6544688cc8ab303bd and set watcher;
> region=usertable,user1951957302,1290501969
> 2010-11-23 00:46:34,531 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Handling
> transition=RS_ZK_REGION_CLOSED,
> server=haus01.sf.cloudera.com,12020,1290501789693,
> region=ffaa7999e909dbd6544688cc8ab303bd
> 2010-11-23 00:46:34,531 WARN
> org.apache.hadoop.hbase.master.AssignmentManager: Received CLOSED for region
> ffaa7999e909dbd6544688cc8ab303bd from server
> haus01.sf.cloudera.com,12020,1290501789693 but region was in the state null
> and not in expected PENDIN
> and the region just gets stuck closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
